New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make animation traits compatible with multiple sprite bodies - part 1 #13294

Merged
merged 4 commits into from May 14, 2017

Conversation

Projects
None yet
3 participants
@reaperrr
Contributor

reaperrr commented May 13, 2017

This adds a Name identifier field to WithSpriteBody, which can be used to make animation traits compatible with multiple sprite bodies.
This is then used to make WithMoveAnimation and WithMakeAnimation compatible with actors that have more than one sprite body (TS artillery and FS Juggernaut, for example).
This allows to remove the deploy animation code from GrantConditionOnDeploy.

Split from #13041, which can also be used as test-case (Juggernaut).

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr May 13, 2017

Contributor

From #13041:

Ping @OpenRA/engine-hackers. This PR is holding up a replacement make animation / buildup trait that @IceReaper is working on for the kknd and mw mods.

Contributor

reaperrr commented May 13, 2017

From #13041:

Ping @OpenRA/engine-hackers. This PR is holding up a replacement make animation / buildup trait that @IceReaper is working on for the kknd and mw mods.

@IceReaper

Looks good in my eyes.

@atlimit8 atlimit8 merged commit d502b29 into OpenRA:bleed May 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@atlimit8

This comment has been minimized.

Show comment
Hide comment
@atlimit8
Member

atlimit8 commented May 14, 2017

@reaperrr reaperrr deleted the reaperrr:MultiSpriteBody-p1 branch Jul 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment