New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rectangle OuterRadius calculation #13340

Merged
merged 4 commits into from May 29, 2017

Conversation

Projects
None yet
4 participants
@reaperrr
Contributor

reaperrr commented May 23, 2017

It didn't take BottomLeft and TopRight corners into consideration, so it could end up too small depending on the positioning of the shape (see screenshots).

Additionally, this PR

  • fixes the D2k repair pad footprint to match the original
  • changes the HitShape debug overlay color from Yellow to GreenYellow, to avoid confusion with voxel render debug shapes
  • adds debug overlays for OuterRadius to Capsule and Rectangle shapes
  • adds debug overlay for TargetablePositions

The goal of this PR is to prevent the next revision of #13314 from growing too large.

Before:
beforefix1

After:
afterfix1

Fix D2k repair pad footprint
To match the original.

@reaperrr reaperrr referenced this pull request May 24, 2017

Merged

Add HitShape trait #13314

@pchote

pchote approved these changes May 25, 2017

Looks good otherwise 👍

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr May 26, 2017

Contributor

Updated.

Contributor

reaperrr commented May 26, 2017

Updated.

@reaperrr reaperrr added this to the Next release milestone May 27, 2017

reaperrr added some commits May 1, 2017

Add OuterRadius debug overlay to Rectangle and Capsule
Circle obviously doesn't need it now (might change with the introduction of offsets, but we can still add it when that happens).
Fix Rectangle OuterRadius
Rectangle shapes always assumed that either top-left or bottom-right would have the largest distance from actor center, which is wrong, because depending on the position of the shape, top-right or bottom-left can be the furthest away corner as well, potentially resulting in a too small OuterRadius.

@atlimit8 atlimit8 merged commit 5834d76 into OpenRA:bleed May 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@atlimit8

This comment has been minimized.

Show comment
Hide comment
@atlimit8
Member

atlimit8 commented May 29, 2017

@reaperrr reaperrr deleted the reaperrr:FixRectangleOuterRadius branch Jul 23, 2017

@reaperrr reaperrr modified the milestones: Next Release, Next + 1 Sep 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment