New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy FileSystem.OpenPackage(string, IReadOnlyPackage). #13345

Merged
merged 1 commit into from May 29, 2017

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented May 24, 2017

Fixes one of the followup items from #13223.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr May 28, 2017

Contributor

Looks good as far as I can tell, map loading, map preview and CheckYaml utility command still work. Haven't tested the rest of the commands due to #13330, but I assume they're fine as well.

Contributor

reaperrr commented May 28, 2017

Looks good as far as I can tell, map loading, map preview and CheckYaml utility command still work. Haven't tested the rest of the commands due to #13330, but I assume they're fine as well.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 May 29, 2017

Member

Looks good to me. 👍 /

Member

abcdefg30 commented May 29, 2017

Looks good to me. 👍 /

@abcdefg30 abcdefg30 merged commit 8321d1f into OpenRA:bleed May 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented May 29, 2017

@pchote pchote deleted the pchote:filesystem-cleanup branch Oct 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment