New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish the windows make and launcher scripts #13359

Merged
merged 5 commits into from Jun 29, 2017

Conversation

Projects
None yet
3 participants
@abcdefg30
Member

abcdefg30 commented May 26, 2017

Fixes issues discovered during the writing/review of OpenRA/OpenRAModSDK#3.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr May 26, 2017

Contributor

Seems to need a rebase.

Contributor

reaperrr commented May 26, 2017

Seems to need a rebase.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 May 26, 2017

Member

Weird, this was already based on latest bleed. I recommited my changes, hopefully that resolves the issue.

Member

abcdefg30 commented May 26, 2017

Weird, this was already based on latest bleed. I recommited my changes, hopefully that resolves the issue.

@pchote

pchote approved these changes Jun 27, 2017

Works as advertised. Just one nit: you have a typo in the second commit message ("commad").

I want this before the playtest for consistency with the mod template, so adding to the milestone.

@pchote pchote added this to the Playtest featuring updated HitShapes milestone Jun 27, 2017

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Jun 28, 2017

Member

Fixed.

Member

abcdefg30 commented Jun 28, 2017

Fixed.

@reaperrr

Can't judge the script changes of 3rd and 5th commit, but they all seem to do what the commit titles suggests.

@reaperrr reaperrr merged commit 04033e5 into OpenRA:bleed Jun 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:make branch Jun 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment