New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2K - Add Harkonnen Mission 4 #13377

Merged
merged 1 commit into from Jun 5, 2017

Conversation

Projects
None yet
4 participants
@MustaphaTR
Member

MustaphaTR commented May 28, 2017

No description provided.

@penev92 penev92 referenced this pull request May 28, 2017

Open

Add Dune 2000 campaign #9287

@CH4Code

This comment has been minimized.

Show comment
Hide comment
@CH4Code

CH4Code Jun 2, 2017

Contributor

Tested the map on easy and hard. On easy in original d2k it is sufficient to destroy one fremen sietch. Seems fine otherwise 👍

Contributor

CH4Code commented Jun 2, 2017

Tested the map on easy and hard. On easy in original d2k it is sufficient to destroy one fremen sietch. Seems fine otherwise 👍

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jun 2, 2017

Member

On easy in original d2k it is sufficient to destroy one fremen sietch.

Are you sure about that, i don't think it is possible to code something like that in vanilla D2k, but i'll test.

Member

MustaphaTR commented Jun 2, 2017

On easy in original d2k it is sufficient to destroy one fremen sietch.

Are you sure about that, i don't think it is possible to code something like that in vanilla D2k, but i'll test.

@CH4Code

This comment has been minimized.

Show comment
Hide comment
@CH4Code

CH4Code Jun 2, 2017

Contributor

Yes, im sure - just palyed it in original dune2k today. I just dont know 100% which difficulty I chose to play the campaign at, most likely easy or normal. Hard is realy tough..^^
The code should be easy...

Trigger.OnKilledOrCaptured(sietch a, primaryfulfilled() )
Trigger.OnKilledOrCaptured(sietch b, primaryfulfilled() ) 
function primaryfulfilled( ) MissionObectives.MarkCompletedObjective(killFremen) end
Contributor

CH4Code commented Jun 2, 2017

Yes, im sure - just palyed it in original dune2k today. I just dont know 100% which difficulty I chose to play the campaign at, most likely easy or normal. Hard is realy tough..^^
The code should be easy...

Trigger.OnKilledOrCaptured(sietch a, primaryfulfilled() )
Trigger.OnKilledOrCaptured(sietch b, primaryfulfilled() ) 
function primaryfulfilled( ) MissionObectives.MarkCompletedObjective(killFremen) end
@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jun 3, 2017

Member

I was talking about original's trigger system, i can code that on Lua. I don't remember anything about difficulty to be in there. I'm checking right now, couldn't find time yet.

Member

MustaphaTR commented Jun 3, 2017

I was talking about original's trigger system, i can code that on Lua. I don't remember anything about difficulty to be in there. I'm checking right now, couldn't find time yet.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jun 3, 2017

Member

That doesn't look correct (8 and 9):
resim

In original different fremen bases have different owners, bottom one is Emparor's actually. That trigger is missing a check for Emparor's Base and Units destroyed. This has nothing to do with difficulty. You probably killed the bases with different order.

I'll consider this as a bug of original game and what happens in this PR (on OpenRA) looks more like a correct behaviour. So i'm not touching anything.

Member

MustaphaTR commented Jun 3, 2017

That doesn't look correct (8 and 9):
resim

In original different fremen bases have different owners, bottom one is Emparor's actually. That trigger is missing a check for Emparor's Base and Units destroyed. This has nothing to do with difficulty. You probably killed the bases with different order.

I'll consider this as a bug of original game and what happens in this PR (on OpenRA) looks more like a correct behaviour. So i'm not touching anything.

@CH4Code

This comment has been minimized.

Show comment
Hide comment
@CH4Code

CH4Code Jun 3, 2017

Contributor

Well, then 👍 from me.

Contributor

CH4Code commented Jun 3, 2017

Well, then 👍 from me.

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem

ltem Jun 3, 2017

Contributor

One question but otherwise 👍

Contributor

ltem commented Jun 3, 2017

One question but otherwise 👍

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jun 5, 2017

Member

Updated.

Member

MustaphaTR commented Jun 5, 2017

Updated.

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem

ltem Jun 5, 2017

Contributor

👍

Contributor

ltem commented Jun 5, 2017

👍

@reaperrr reaperrr merged commit 46d0157 into OpenRA:bleed Jun 5, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:d2k-harkonnen-4 branch Jun 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment