New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AppearsOnRadar Conditional & Player Stance Awear #13386

Merged
merged 2 commits into from Aug 25, 2017

Conversation

Projects
None yet
5 participants
@atlimit8
Member

atlimit8 commented May 29, 2017

This can be used to implement radar invisibility as mentioned in #13209.

@atlimit8 atlimit8 added this to the Tiberian Sun Public Alpha milestone May 29, 2017

@pchote

What if we added a fixed ValidStances field and made the trait Conditional, and then have separate trait instances for enemy/neutral vs ally for actors that can become radar invisible?

Show outdated Hide outdated OpenRA.Mods.Common/Traits/Radar/AppearsOnRadar.cs Outdated
@atlimit8

This comment has been minimized.

Show comment
Hide comment
@atlimit8

atlimit8 May 29, 2017

Member

I am OK with the idea of using ValidStances and basing it on ConditionalTrait.

Member

atlimit8 commented May 29, 2017

I am OK with the idea of using ValidStances and basing it on ConditionalTrait.

@atlimit8

This comment has been minimized.

Show comment
Hide comment
@atlimit8

atlimit8 May 29, 2017

Member

Updated.

Member

atlimit8 commented May 29, 2017

Updated.

@atlimit8 atlimit8 changed the title from Add ShowOnCondition & ShowEnemyOnCondition to AppearsOnRadar trait to Make AppearsOnRadar Conditional May 29, 2017

@atlimit8

This comment has been minimized.

Show comment
Hide comment
@atlimit8

atlimit8 Jun 14, 2017

Member

Added replay handling.

Member

atlimit8 commented Jun 14, 2017

Added replay handling.

@atlimit8 atlimit8 changed the title from Make AppearsOnRadar Conditional to Make AppearsOnRadar Conditional & Player Stance Awear Jun 14, 2017

@pchote

Works as advertised, otherwise.

@atlimit8

This comment has been minimized.

Show comment
Hide comment
@atlimit8

atlimit8 Jul 24, 2017

Member

Applied fix-up.

Member

atlimit8 commented Jul 24, 2017

Applied fix-up.

@rob-v

rob-v approved these changes Jul 31, 2017

👍

Show outdated Hide outdated OpenRA.Mods.Common/Traits/Radar/AppearsOnRadar.cs Outdated

@reaperrr reaperrr merged commit 43880ea into OpenRA:bleed Aug 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment