New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2K - Reimport Habbanya Erg and Imperial Basin #13399

Merged
merged 1 commit into from Jul 2, 2017

Conversation

Projects
None yet
5 participants
@MustaphaTR
Member

MustaphaTR commented May 30, 2017

I'm not sure what exactly are changed but those maps should be same as original now, if they weren't.

http://resource.openra.net/maps/21623/
http://resource.openra.net/maps/21621/

@obrakmann

This comment has been minimized.

Show comment
Hide comment
@obrakmann

obrakmann Jun 1, 2017

Contributor

err... if you weren't aware of any problems with the maps, why did you reimport them?

Contributor

obrakmann commented Jun 1, 2017

err... if you weren't aware of any problems with the maps, why did you reimport them?

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem

ltem Jun 1, 2017

Contributor

Hmm the wormspawner positions could be polished/rearranged. Right now it seems that certain player spawn points have an advantage.

Contributor

ltem commented Jun 1, 2017

Hmm the wormspawner positions could be polished/rearranged. Right now it seems that certain player spawn points have an advantage.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jun 3, 2017

Member

err... if you weren't aware of any problems with the maps, why did you reimport them?

Those maps are added before #12784, so it was clear that they had errors, some tiles possibly didn't even exists before that PR. I manually fixed brokenly imported tiles for Habbanya Erg, and old Imperial Basin was possibly also suffering that, i wanted to reimport them while importing other 8PLAYX maps too. That was what i was thinking.

I just compared them to be sure. Imperal Basin had some wrong, even missing rock-detail tiles. It was also missing Dunes. Habbanya Erg just had wrong rock-detail tiles that are now fixed with reimport.

Hmm the wormspawner positions could be polished/rearranged. Right now it seems that certain player spawn points have an advantage.

It looks like old Imperal Basin had manually placed Worm Spawners, which are changed to their original locations with this PR. I haven't touched to Habbanya Erg when adding it first. I'll take a look to that.

Member

MustaphaTR commented Jun 3, 2017

err... if you weren't aware of any problems with the maps, why did you reimport them?

Those maps are added before #12784, so it was clear that they had errors, some tiles possibly didn't even exists before that PR. I manually fixed brokenly imported tiles for Habbanya Erg, and old Imperial Basin was possibly also suffering that, i wanted to reimport them while importing other 8PLAYX maps too. That was what i was thinking.

I just compared them to be sure. Imperal Basin had some wrong, even missing rock-detail tiles. It was also missing Dunes. Habbanya Erg just had wrong rock-detail tiles that are now fixed with reimport.

Hmm the wormspawner positions could be polished/rearranged. Right now it seems that certain player spawn points have an advantage.

It looks like old Imperal Basin had manually placed Worm Spawners, which are changed to their original locations with this PR. I haven't touched to Habbanya Erg when adding it first. I'll take a look to that.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jun 27, 2017

Member

Any progress here @MustaphaTR?

Member

pchote commented Jun 27, 2017

Any progress here @MustaphaTR?

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jun 28, 2017

Member

I just took a look to that, but couldn't really find any better location for wormspawners. Actually Habbanya Erg ones look pretty balanced to me. Unless @ltem you have a better idea, imo we can go with PR as is.

Member

MustaphaTR commented Jun 28, 2017

I just took a look to that, but couldn't really find any better location for wormspawners. Actually Habbanya Erg ones look pretty balanced to me. Unless @ltem you have a better idea, imo we can go with PR as is.

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem

ltem Jun 29, 2017

Contributor

I'm fine with Habbanya Erg but I think that the upper left player in Imperial Basin has an advantage due to the lack of a worm spawner close to him but if we just added one it seems to alter the situation for him to a disadvantage.

Possible solutions:

  1. We add it as it is (we wait for feedback from the players)
  2. We try to balance all the worm spawners of Imperial Basin
  3. We don't add the map ( :( )

I favor solution 1 and so I would approve this PR 👍

Contributor

ltem commented Jun 29, 2017

I'm fine with Habbanya Erg but I think that the upper left player in Imperial Basin has an advantage due to the lack of a worm spawner close to him but if we just added one it seems to alter the situation for him to a disadvantage.

Possible solutions:

  1. We add it as it is (we wait for feedback from the players)
  2. We try to balance all the worm spawners of Imperial Basin
  3. We don't add the map ( :( )

I favor solution 1 and so I would approve this PR 👍

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jun 29, 2017

Contributor

I'd vote for 1, too. If worms become too big of a problem, we can still try to rebalance them (or remove the spawners entirely).
I'll wait a bit with merging to give others time to respond if they disagree, though.

Contributor

reaperrr commented Jun 29, 2017

I'd vote for 1, too. If worms become too big of a problem, we can still try to rebalance them (or remove the spawners entirely).
I'll wait a bit with merging to give others time to respond if they disagree, though.

@reaperrr reaperrr merged commit 6dca6b3 into OpenRA:bleed Jul 2, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Jul 2, 2017

@MustaphaTR MustaphaTR deleted the MustaphaTR:reimport-8PLAY3-and-5 branch Jul 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment