New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RangeCircleMode to trait RenderRangeCircle #13431

Merged
merged 1 commit into from Jul 11, 2017

Conversation

Projects
None yet
7 participants
@jrb0001
Contributor

jrb0001 commented Jun 2, 2017

No description provided.

@chrisforbes

This comment has been minimized.

Show comment
Hide comment
@chrisforbes

chrisforbes Jun 3, 2017

Member

One oddity here is that the alpha values are still hardcoded.

Member

chrisforbes commented Jun 3, 2017

One oddity here is that the alpha values are still hardcoded.

@GraionDilach

Needs to be squashed and maybe giving fullstops to the descriptions, but overall IMO it's good now.

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem

ltem Jul 11, 2017

Contributor

EDIT: Not related to this PR, a rebase against bleed solved it.

hmm Openra crashes with this PR when I try to build an Obelisk of Light.

Exception.log:

Tiberian Dawn Mod at Version {DEV_VERSION}
on map 084b4bddd86b79671048f3fd289e3c68c1ce4886 (X896 by pulse).
Date: 2017-07-11 21:05:12Z
Operating System: Linux (Unix 3.16.0.4)
Runtime Version: Mono 3.2.8 (Debian 3.2.8+dfsg-10) CLR 4.0.30319.17020
Exception of type `System.NullReferenceException`: Object reference not set to an instance of an object
  at OpenRA.Mods.Common.Traits.AttackBase.get_Armaments () [0x00000] in <filename unknown>:0 
  at OpenRA.Mods.Common.Traits.AttackBase.UnforcedAttackTargetStances () [0x00000] in <filename unknown>:0 
  at OpenRA.Mods.Common.Traits.AutoTarget.ScanForTarget (OpenRA.Actor self, Boolean allowMove) [0x00000] in <filename unknown>:0 
  at OpenRA.Mods.Common.Traits.AutoTarget.ScanAndAttack (OpenRA.Actor self, Boolean allowMove) [0x00000] in <filename unknown>:0 
  at OpenRA.Mods.Common.Traits.AutoTarget.TickIdle (OpenRA.Actor self) [0x00000] in <filename unknown>:0 
  at OpenRA.World.Tick () [0x00000] in <filename unknown>:0 
  at OpenRA.Game.InnerLogicTick (OpenRA.Network.OrderManager orderManager) [0x00000] in <filename unknown>:0 
  at OpenRA.Game.LogicTick () [0x00000] in <filename unknown>:0 
  at OpenRA.Game.Loop () [0x00000] in <filename unknown>:0 
  at OpenRA.Game.Run () [0x00000] in <filename unknown>:0 
  at OpenRA.Program.Run (System.String[] args) [0x00000] in <filename unknown>:0 
  at OpenRA.Program.Main (System.String[] args) [0x00000] in <filename unknown>:0 

Debug.log Edit: removed due to being unnecessary and too long.

Contributor

ltem commented Jul 11, 2017

EDIT: Not related to this PR, a rebase against bleed solved it.

hmm Openra crashes with this PR when I try to build an Obelisk of Light.

Exception.log:

Tiberian Dawn Mod at Version {DEV_VERSION}
on map 084b4bddd86b79671048f3fd289e3c68c1ce4886 (X896 by pulse).
Date: 2017-07-11 21:05:12Z
Operating System: Linux (Unix 3.16.0.4)
Runtime Version: Mono 3.2.8 (Debian 3.2.8+dfsg-10) CLR 4.0.30319.17020
Exception of type `System.NullReferenceException`: Object reference not set to an instance of an object
  at OpenRA.Mods.Common.Traits.AttackBase.get_Armaments () [0x00000] in <filename unknown>:0 
  at OpenRA.Mods.Common.Traits.AttackBase.UnforcedAttackTargetStances () [0x00000] in <filename unknown>:0 
  at OpenRA.Mods.Common.Traits.AutoTarget.ScanForTarget (OpenRA.Actor self, Boolean allowMove) [0x00000] in <filename unknown>:0 
  at OpenRA.Mods.Common.Traits.AutoTarget.ScanAndAttack (OpenRA.Actor self, Boolean allowMove) [0x00000] in <filename unknown>:0 
  at OpenRA.Mods.Common.Traits.AutoTarget.TickIdle (OpenRA.Actor self) [0x00000] in <filename unknown>:0 
  at OpenRA.World.Tick () [0x00000] in <filename unknown>:0 
  at OpenRA.Game.InnerLogicTick (OpenRA.Network.OrderManager orderManager) [0x00000] in <filename unknown>:0 
  at OpenRA.Game.LogicTick () [0x00000] in <filename unknown>:0 
  at OpenRA.Game.Loop () [0x00000] in <filename unknown>:0 
  at OpenRA.Game.Run () [0x00000] in <filename unknown>:0 
  at OpenRA.Program.Run (System.String[] args) [0x00000] in <filename unknown>:0 
  at OpenRA.Program.Main (System.String[] args) [0x00000] in <filename unknown>:0 

Debug.log Edit: removed due to being unnecessary and too long.

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach Jul 11, 2017

Contributor

That crash doesn't seem to be related to what this PR is doing. Try rebasing the commit against current bleed.

Contributor

GraionDilach commented Jul 11, 2017

That crash doesn't seem to be related to what this PR is doing. Try rebasing the commit against current bleed.

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem

ltem Jul 11, 2017

Contributor

@GraionDilach thanks, you're right, the crash is gone after I rebased it.

Contributor

ltem commented Jul 11, 2017

@GraionDilach thanks, you're right, the crash is gone after I rebased it.

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach Jul 11, 2017

Contributor

@OpenRA/engine-hackers note that this has been squashed silently so the fixup requested tag isn't valid by now.

Contributor

GraionDilach commented Jul 11, 2017

@OpenRA/engine-hackers note that this has been squashed silently so the fixup requested tag isn't valid by now.

@reaperrr reaperrr merged commit 6749060 into OpenRA:bleed Jul 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jrb0001 jrb0001 deleted the jrb0001:renderrangecircle branch Jul 12, 2017

jrb0001 added a commit to DoGyAUT/OpenRA that referenced this pull request Jul 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment