New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Railgun projectile #13463

Merged
merged 1 commit into from Jul 21, 2017

Conversation

Projects
None yet
6 participants
@forcecore
Contributor

forcecore commented Jun 6, 2017

I hope this looks good
https://youtu.be/tHJgJtj-Utk

@rob-v

This comment has been minimized.

Show comment
Hide comment
@rob-v

rob-v Jun 6, 2017

Contributor

It looks great. I played one game with it, works fine with units, doesn't work with buildings. You need to force attack behind building to do damage:
obrazok

Contributor

rob-v commented Jun 6, 2017

It looks great. I played one game with it, works fine with units, doesn't work with buildings. You need to force attack behind building to do damage:
obrazok

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jun 6, 2017

Member

doesn't work with buildings. You need to force attack behind building to do damage:

That is caused by the ongoing targeting rework, and not part of this PR.

Member

pchote commented Jun 6, 2017

doesn't work with buildings. You need to force attack behind building to do damage:

That is caused by the ongoing targeting rework, and not part of this PR.

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Jun 6, 2017

Contributor

Now that TS mod works with new bleed head, rebased. Helix line segment drawing pulled out of the loop.

Contributor

forcecore commented Jun 6, 2017

Now that TS mod works with new bleed head, rebased. Helix line segment drawing pulled out of the loop.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jun 6, 2017

Contributor

It looks great. I played one game with it, works fine with units, doesn't work with buildings. You need to force attack behind building to do damage:

Will be fixed once #13464 is finished and merged.

Contributor

reaperrr commented Jun 6, 2017

It looks great. I played one game with it, works fine with units, doesn't work with buildings. You need to force attack behind building to do damage:

Will be fixed once #13464 is finished and merged.

@reaperrr reaperrr added this to the Tiberian Sun Public Alpha milestone Jun 23, 2017

@abcdefg30

Looks good otherwise. 👍 Great work!

Show outdated Hide outdated OpenRA.Mods.Common/Graphics/RailgunRenderable.cs Outdated
Show outdated Hide outdated OpenRA.Mods.Common/Graphics/RailgunRenderable.cs Outdated
Show outdated Hide outdated OpenRA.Mods.Common/Graphics/RailgunRenderable.cs Outdated
Show outdated Hide outdated OpenRA.Mods.Common/Projectiles/Railgun.cs Outdated
Show outdated Hide outdated OpenRA.Mods.Common/Projectiles/Railgun.cs Outdated
Show outdated Hide outdated OpenRA.Mods.Common/Projectiles/Railgun.cs Outdated
Show outdated Hide outdated OpenRA.Mods.Common/Projectiles/Railgun.cs Outdated
Show outdated Hide outdated OpenRA.Mods.Common/Projectiles/Railgun.cs Outdated
Show outdated Hide outdated OpenRA.Mods.Common/Projectiles/Railgun.cs Outdated
Show outdated Hide outdated OpenRA.Mods.Common/Projectiles/Railgun.cs Outdated
@abcdefg30

I think this is good to go once the last two nits are resolved and the commits are squashed.

Show outdated Hide outdated OpenRA.Mods.Common/Projectiles/Railgun.cs Outdated
Show outdated Hide outdated OpenRA.Mods.Common/Projectiles/Railgun.cs Outdated
@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Jul 15, 2017

Contributor

Rebased, squashed and the last two issues addressed.

Contributor

forcecore commented Jul 15, 2017

Rebased, squashed and the last two issues addressed.

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Jul 16, 2017

Contributor
  • HelixAlphaDeltaPerTick wasn't in effect.
  • Player color laser/helix will now use Helix/Laser color's alpha information, not hard coded 128 as alpha.
Contributor

forcecore commented Jul 16, 2017

  • HelixAlphaDeltaPerTick wasn't in effect.
  • Player color laser/helix will now use Helix/Laser color's alpha information, not hard coded 128 as alpha.
@pchote

This looks quite nice. I have a few minor requests:

Show outdated Hide outdated OpenRA.Mods.Common/Graphics/RailgunRenderable.cs Outdated
Show outdated Hide outdated OpenRA.Mods.Common/Projectiles/Railgun.cs Outdated
Show outdated Hide outdated OpenRA.Mods.Common/Projectiles/Railgun.cs Outdated
Show outdated Hide outdated OpenRA.Mods.Common/Projectiles/Railgun.cs Outdated
Show outdated Hide outdated OpenRA.Mods.Common/Projectiles/Railgun.cs Outdated
@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Jul 16, 2017

Contributor

Hopefully the last commit :D?

Contributor

forcecore commented Jul 16, 2017

Hopefully the last commit :D?

@pchote

pchote approved these changes Jul 21, 2017

@pchote pchote merged commit 0573f52 into OpenRA:bleed Jul 21, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@forcecore forcecore deleted the forcecore:railgun branch Aug 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment