New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash in CheckSequences when the sprite image is null #13466

Merged
merged 2 commits into from Jun 22, 2017

Conversation

Projects
None yet
3 participants
@abcdefg30
Member

abcdefg30 commented Jun 6, 2017

CheckDefintions will crash when imageOverride is null anyway.

@rob-v

rob-v approved these changes Jun 12, 2017 edited

👍
I didn't know how to simulate such case in .yaml, but works properly.

if (!string.IsNullOrEmpty(imageOverride) && sequenceDefinitions.All(s => s.Key != imageOverride.ToLowerInvariant()))
if (string.IsNullOrEmpty(imageOverride))
{
emitWarning("Custom sprite image of actor {0} is null.".F(actorInfo.Value.Name));

This comment has been minimized.

@rob-v

rob-v Jun 12, 2017

Contributor

not important - 'image of actor' vs below 'image {0} from actor'

@rob-v

rob-v Jun 12, 2017

Contributor

not important - 'image of actor' vs below 'image {0} from actor'

@reaperrr reaperrr merged commit 118039d into OpenRA:bleed Jun 22, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Jun 22, 2017

@abcdefg30 abcdefg30 deleted the abcdefg30:lintCrash branch Jun 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment