Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor targeting of target center and fix pillbox regression #13529
Pillboxes (and possibly other actors in external mods) themselves don't have an Attack* trait, so the previous approach would prevent them from working.
Update: Refactored #13497 due to
(which I agree with anyway, the old approach was only taken to avoid an additional projectile arg).
referenced this pull request
Jun 18, 2017
Not sure. I imagine it might be tricky because the Attack/Turreted traits need that information to face the correct position, but what if one weapon has AttackTargetCenter while the other doesn't?
I suspect we might be opening a bigger can of worms than we're closing if we do that.
I remember I wanted to ask about that CheckFire's return added in last commit but deferred..
We already have this issue. If any turrets has a valid facing towards the targets, all are allowed to fire. http://ppmforums.com/viewtopic.php?t=42445 have illustrated this ages ago. I doubt that would cause new issues.
12:04:27 (abcdefg30) pchote are you going to insist on #13529 (comment) or do we leave that to a future pr (if it happens)?
12:06:13 (pchote) I am tempted to, yes
12:06:52 (pchote) if we don't fix this properly before we ship a playtest it becomes much harder
Note: I'm not 100% sure what to do with Turreted.