New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2k: Change concrete radar color to match rock. #13537

Merged
merged 1 commit into from Jun 27, 2017

Conversation

Projects
None yet
4 participants
@CH4Code
Contributor

CH4Code commented Jun 23, 2017

This is/was problematic, because right now players can spot expansions through the fog-of-war instantly.
This replicates original game behavior, too. Concrete in original dune2k doesn't show up on the radar.
It changes the concrete radar color to the rock radar color so the two are indistinguishable.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jun 23, 2017

Member

This doesn't do anything with regards to the fog (that requires a much deeper fix, unifying behaviour with resources, smudges etc). Please change the commit message to "Change concrete radar color to match rock".

Member

pchote commented Jun 23, 2017

This doesn't do anything with regards to the fog (that requires a much deeper fix, unifying behaviour with resources, smudges etc). Please change the commit message to "Change concrete radar color to match rock".

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem

ltem Jun 23, 2017

Contributor

If it is like that in the original game I'm not against it but in my opinion a better solution would be, if it is fixed in the same way the resource visibility bug #5908 will (possibly) be solved. So that the minimap/fog only gets updated if the player has actually visual contact of the area.

Contributor

ltem commented Jun 23, 2017

If it is like that in the original game I'm not against it but in my opinion a better solution would be, if it is fixed in the same way the resource visibility bug #5908 will (possibly) be solved. So that the minimap/fog only gets updated if the player has actually visual contact of the area.

@CH4Code CH4Code changed the title from D2k: Fixes concrete being visible to all players through fog. to D2k: Change concrete radar color to match rock. Jun 23, 2017

Change concrete radar color to match rock.
This is/was problematic, because right now players can spot expansions through the fog-of-war instantly.
This replicates original game behavior, too. Concrete in original dune2k doesn't show up on the radar.
@CH4Code

This comment has been minimized.

Show comment
Hide comment
@CH4Code

CH4Code Jun 23, 2017

Contributor

original game:
radar

Contributor

CH4Code commented Jun 23, 2017

original game:
radar

@ltem

ltem approved these changes Jun 24, 2017

Works as described and matches the behavior of the original game (checked via Gruntmods).

@reaperrr reaperrr merged commit 8a508ec into OpenRA:bleed Jun 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment