New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a global script for campaign missions in d2k #13592

Merged
merged 8 commits into from Aug 17, 2017

Conversation

Projects
None yet
4 participants
@abcdefg30
Member

abcdefg30 commented Jul 5, 2017

Especially the AI methods were duplicated a lot. Fixes also some other bugs/oversights (+ general polish).

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jul 19, 2017

Member

That last commit is only applied for Atr1 and Atr3. Har1 and Ord1 are also spice collecting missions.

It looks like AI is using starting units (given with lua as in here, not preplaced ones), that are meant to guard their base, to attack. It is pretty earlygame so it makes stuff a bit hard. They were previously added to IdlingUnits too, i'm not sure why it is happening now but didn't used to. Maybe we shouldn't add them to.

Member

MustaphaTR commented Jul 19, 2017

That last commit is only applied for Atr1 and Atr3. Har1 and Ord1 are also spice collecting missions.

It looks like AI is using starting units (given with lua as in here, not preplaced ones), that are meant to guard their base, to attack. It is pretty earlygame so it makes stuff a bit hard. They were previously added to IdlingUnits too, i'm not sure why it is happening now but didn't used to. Maybe we shouldn't add them to.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Jul 19, 2017

Member

They were previously added to IdlingUnits too, i'm not sure why it is happening now but didn't used to. Maybe we shouldn't add them to.

Hm, that is weird. The should attack on latest bleed as well.

Member

abcdefg30 commented Jul 19, 2017

They were previously added to IdlingUnits too, i'm not sure why it is happening now but didn't used to. Maybe we shouldn't add them to.

Hm, that is weird. The should attack on latest bleed as well.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jul 19, 2017

Member

Oh, wait starting units is not the issue. On bleed AI doesn't attack with everthing they built/have in IdlingUnits, in this PR it does, causing attack force to bigger and harder to counter compared to bleed.

Member

MustaphaTR commented Jul 19, 2017

Oh, wait starting units is not the issue. On bleed AI doesn't attack with everthing they built/have in IdlingUnits, in this PR it does, causing attack force to bigger and harder to counter compared to bleed.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Aug 7, 2017

Member

That last commit is only applied for Atr1 and Atr3. Har1 and Ord1 are also spice collecting missions.

Fixed.

On bleed AI doesn't attack with everthing they built/have in IdlingUnits, in this PR it does, causing attack force to bigger and harder to counter compared to bleed.

Ah, I see. Fixed, thanks.

I also made the Fremen less aggressive on Atreides04 as discussed on IRC (a while back) and fixed some other bugs.

Member

abcdefg30 commented Aug 7, 2017

That last commit is only applied for Atr1 and Atr3. Har1 and Ord1 are also spice collecting missions.

Fixed.

On bleed AI doesn't attack with everthing they built/have in IdlingUnits, in this PR it does, causing attack force to bigger and harder to counter compared to bleed.

Ah, I see. Fixed, thanks.

I also made the Fremen less aggressive on Atreides04 as discussed on IRC (a while back) and fixed some other bugs.

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem

ltem Aug 14, 2017

Contributor

👍

  • Add a global script for campaign missions in d2k ✔️
  • Add a warning when attacking the Outpost to ordos04 ✔️
  • Fix the harvest protection logic ✔️
  • Fix a bogus condition ✔️
  • Add more fail conditions to the spice harvesting missions
  • Let the fremen fallback in atreides04 instead of attacking the base ✔️
  • Fix sietches being repairable and remove the Power trait (unused) ✔️
  • Fix actors being able to walk on cliffs after the sietch was destroyed ✔️
Contributor

ltem commented Aug 14, 2017

👍

  • Add a global script for campaign missions in d2k ✔️
  • Add a warning when attacking the Outpost to ordos04 ✔️
  • Fix the harvest protection logic ✔️
  • Fix a bogus condition ✔️
  • Add more fail conditions to the spice harvesting missions
  • Let the fremen fallback in atreides04 instead of attacking the base ✔️
  • Fix sietches being repairable and remove the Power trait (unused) ✔️
  • Fix actors being able to walk on cliffs after the sietch was destroyed ✔️
@ltem

ltem approved these changes Aug 14, 2017

@reaperrr reaperrr merged commit 6840177 into OpenRA:bleed Aug 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:d2kGlobal branch Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment