Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add search fields to the map editor template and actor lists. #13596
This PR wraps up @rob-v's editor improvements by adding a search field to filter actors/tiles by name/id/category/tooltip. It also adds the template ID to the current cell display so that mappers can quickly identify and filter/select any tile on the map.
referenced this pull request
Jul 5, 2017
It is great! I am glad I closed my PR as this is improved and with additional optimizations.
Only small issues +
I am not sure about the inclusion of categories in search terms. E.g. I search for 'Civilian'. Usually you see actors where search term is in the name or tooltip, but if there is also category with such name, there are/could be many other actors without search term in name so you need to search manually.
It might be better to remove categories from search term as they can be already filtered out by selecting categories in the list - my feeling was that it is little confusing as the results aren't consistent (that search term is in tooltip).
note(issue): you start with e.g. None. search for 1tnk. There are 2 filtered categories. When you use 'All', not only these 2 categories are selected, but when you delete search text, all categories are selected. Maybe not better/simple to select with All/None only visible/fitlered categories?
IMO this behaviour is more logical than having the "all" button hide categories after returning if you press it while searching.
Actually, (assuming we mean the same thing), I agree with @rob-v. If I had selected 'None' before I start typing into the search field, I'd expect the editor to automatically switch to 'Search Results' as soon as I type in anything. Having to manually switch from None to All or select one of the listed categories to see what the search found is not intuitive, in my opinion.