New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX game hang when units with 0 min-range attack units at 0 range. #13608

Merged
merged 1 commit into from Jul 12, 2017

Conversation

Projects
None yet
4 participants
@forcecore
Contributor

forcecore commented Jul 8, 2017

Fixes #13307

@reaperrr

Otherwise looks good.

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Jul 9, 2017

Contributor

Now using cached pos instead of self.CenterPosition.

Contributor

forcecore commented Jul 9, 2017

Now using cached pos instead of self.CenterPosition.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jul 11, 2017

Contributor

This is a simple enough fix that should go into the playtest.

Contributor

reaperrr commented Jul 11, 2017

This is a simple enough fix that should go into the playtest.

@reaperrr reaperrr added this to the Playtest featuring updated HitShapes milestone Jul 11, 2017

@GraionDilach

👍 Very well done.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Jul 12, 2017

Member

Thanks for fixing this. The freeze is gone as advertised. 👍 /

Member

abcdefg30 commented Jul 12, 2017

Thanks for fixing this. The freeze is gone as advertised. 👍 /

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Jul 12, 2017

Contributor

Removed tabs

Contributor

forcecore commented Jul 12, 2017

Removed tabs

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jul 12, 2017

Contributor

@forcecore This looks good now, but could you also squash the commits? For such small fixes it's better to have everything in one commit.

Contributor

reaperrr commented Jul 12, 2017

@forcecore This looks good now, but could you also squash the commits? For such small fixes it's better to have everything in one commit.

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Jul 12, 2017

Contributor

Squashed.

Contributor

forcecore commented Jul 12, 2017

Squashed.

@reaperrr reaperrr merged commit 801796b into OpenRA:bleed Jul 12, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@forcecore forcecore deleted the forcecore:ZeroRangeHangFix branch Jul 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment