New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code style checking to its own executable. #13611

Merged
merged 1 commit into from Jul 9, 2017

Conversation

Projects
None yet
4 participants
@pchote
Member

pchote commented Jul 8, 2017

Depends on and followup to #13602. This moves the code-style checks from the utility to its own dedicated executable so that we can remove the Stylecop dependency from Mods.Common.

OpenRA.StyleCheck.exe is licensed under MS-PL to resolve the issues with GPL vs MS-PL compatibility.

@pchote pchote added this to the Playtest featuring updated HitShapes milestone Jul 8, 2017

@RoosterDragon

This comment has been minimized.

Show comment
Hide comment
@RoosterDragon

RoosterDragon Jul 8, 2017

Member

Could you adjust Check-Command inmake.ps1 similarly?

Member

RoosterDragon commented Jul 8, 2017

Could you adjust Check-Command inmake.ps1 similarly?

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jul 8, 2017

Member

Good catch. Fixed.

Member

pchote commented Jul 8, 2017

Good catch. Fixed.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jul 8, 2017

Member

Rebased.

Member

pchote commented Jul 8, 2017

Rebased.

@rob-v

rob-v approved these changes Jul 9, 2017

👍, makefile not tested, but lgtm

@reaperrr reaperrr merged commit e38db04 into OpenRA:bleed Jul 9, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:stylecop-exe branch Oct 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment