New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infantry staying out of range #13620

Merged
merged 1 commit into from Jul 15, 2017

Conversation

Projects
None yet
5 participants
@reaperrr
Contributor

reaperrr commented Jul 11, 2017

Closes #5841.

@reaperrr reaperrr added this to the Playtest featuring updated HitShapes milestone Jul 11, 2017

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jul 11, 2017

Contributor

Should go into playtest, in my opinion.
It's an annoying, long-standing bug and a relatively simple fix.

Contributor

reaperrr commented Jul 11, 2017

Should go into playtest, in my opinion.
It's an annoying, long-standing bug and a relatively simple fix.

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Jul 12, 2017

Contributor

Now I see why infantries are staring at each other in AI vs AI games

Contributor

forcecore commented Jul 12, 2017

Now I see why infantries are staring at each other in AI vs AI games

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jul 14, 2017

Contributor

Updated, but left the fixup as separate commit for now in case it needs more changes.

Contributor

reaperrr commented Jul 14, 2017

Updated, but left the fixup as separate commit for now in case it needs more changes.

@pchote pchote dismissed their stale review Jul 14, 2017

Code updated.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jul 15, 2017

Contributor

Squashed commits.

Contributor

reaperrr commented Jul 15, 2017

Squashed commits.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Jul 15, 2017

Member

Still works, and my 👍 still stands.

Member

abcdefg30 commented Jul 15, 2017

Still works, and my 👍 still stands.

@GraionDilach

LGTM. I consider this a must for the playtest tbh.

@reaperrr reaperrr merged commit 86ab6e7 into OpenRA:bleed Jul 15, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reaperrr reaperrr deleted the reaperrr:fix-IsInRange branch Jul 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment