New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio device names is now shown correctly in the Audio Device combolist. #13621

Merged
merged 1 commit into from Aug 13, 2017

Conversation

Projects
None yet
5 participants
@SoftAllan
Contributor

SoftAllan commented Jul 11, 2017

Ignored DA version of resource dll.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jul 11, 2017

Member

@RoosterDragon can you comment on this re #12167 and #12150?

Member

pchote commented Jul 11, 2017

@RoosterDragon can you comment on this re #12167 and #12150?

@SoftAllan

This comment has been minimized.

Show comment
Hide comment
@SoftAllan

SoftAllan Jul 11, 2017

Contributor

The screenshot below shows the encoding done with Default that uses the default system codepage. In this case the ISO-8859-1 codepage:
audiodevicebefore

It should be an UTF-8 encoding instead. This is after the change in the code:
audiodeviceafter

Contributor

SoftAllan commented Jul 11, 2017

The screenshot below shows the encoding done with Default that uses the default system codepage. In this case the ISO-8859-1 codepage:
audiodevicebefore

It should be an UTF-8 encoding instead. This is after the change in the code:
audiodeviceafter

Show outdated Hide outdated .gitignore
@RoosterDragon

This comment has been minimized.

Show comment
Hide comment
@RoosterDragon

RoosterDragon Jul 17, 2017

Member

Looks like UTF8 is the correct encoding. Don't know why I couldn't find that at the time, but I'm glad somebody noticed and made it better :)

👍 modulo Graion's question.

Member

RoosterDragon commented Jul 17, 2017

Looks like UTF8 is the correct encoding. Don't know why I couldn't find that at the time, but I'm glad somebody noticed and made it better :)

👍 modulo Graion's question.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Aug 13, 2017

Member

Removed the changes to .gitignore.

Member

abcdefg30 commented Aug 13, 2017

Removed the changes to .gitignore.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Aug 13, 2017

Member

This also got a second 👍 from @netnazgul (see #13837).

Member

abcdefg30 commented Aug 13, 2017

This also got a second 👍 from @netnazgul (see #13837).

@abcdefg30 abcdefg30 merged commit 5435e34 into OpenRA:bleed Aug 13, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Aug 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment