New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Generals Pilot Logic #13623

Merged
merged 1 commit into from Sep 14, 2017

Conversation

Projects
None yet
6 participants
@MustaphaTR
Member

MustaphaTR commented Jul 12, 2017

Pretty much a copy-paste from DeliversCash stuff. Entering actor gives the levels it has to target. For testcase i gave E1 pilot ability.

Edit: What Travis isn't happy about is something to do with testcase/mission maps so you can ignore it.

@MunWolf

This comment has been minimized.

Show comment
Hide comment
@MunWolf

MunWolf Jul 12, 2017

Contributor

As @abcdefg30 said, especially since you have a requires on the trait so you will never encounter a situation where TraitOrDefault is null.
That makes Trait<> better as it omits some checks that TraitOrDefault<> is forced to do.

Contributor

MunWolf commented Jul 12, 2017

As @abcdefg30 said, especially since you have a requires on the trait so you will never encounter a situation where TraitOrDefault is null.
That makes Trait<> better as it omits some checks that TraitOrDefault<> is forced to do.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jul 12, 2017

Member

Updated.

Member

MustaphaTR commented Jul 12, 2017

Updated.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jul 17, 2017

Member

Updated.

Member

MustaphaTR commented Jul 17, 2017

Updated.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jul 17, 2017

Member

Updated.

Member

MustaphaTR commented Jul 17, 2017

Updated.

@abcdefg30

You should add a target != sell check at the beginning of CanTargetActor (and CanTargetActorFrozenActor). 👍 after that.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jul 18, 2017

Member

Updated and added target == self check for CanTargetActor. It doesn't look like i can do the same for CanTargetActorFrozenActor as appearantly i can't compare a FrozenActor. Which i don't think is necessary as your own/allies units can't be frozen (even if they enter fog with RevealsShroud: > Range: 0c0) anyway.

Member

MustaphaTR commented Jul 18, 2017

Updated and added target == self check for CanTargetActor. It doesn't look like i can do the same for CanTargetActorFrozenActor as appearantly i can't compare a FrozenActor. Which i don't think is necessary as your own/allies units can't be frozen (even if they enter fog with RevealsShroud: > Range: 0c0) anyway.

@MunWolf

This comment has been minimized.

Show comment
Hide comment
@MunWolf

MunWolf Jul 18, 2017

Contributor

@MustaphaTR You can do FrozenActor.Actor to do the check, if you still need to do it.

Contributor

MunWolf commented Jul 18, 2017

@MustaphaTR You can do FrozenActor.Actor to do the check, if you still need to do it.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jul 18, 2017

Member

Actually ValidStances: tag exists for AcceptsDeliveredExperience: so one may set it to enemy (even tho i don't see a reason for that) which can have frozen actors, it's better to check.

Member

MustaphaTR commented Jul 18, 2017

Actually ValidStances: tag exists for AcceptsDeliveredExperience: so one may set it to enemy (even tho i don't see a reason for that) which can have frozen actors, it's better to check.

@MunWolf

This comment has been minimized.

Show comment
Hide comment
@MunWolf

MunWolf Jul 18, 2017

Contributor

A unit which gives the enemy experience but sets it on a timer to explode in a minute ;)
Creative stuff like that I guess.

Contributor

MunWolf commented Jul 18, 2017

A unit which gives the enemy experience but sets it on a timer to explode in a minute ;)
Creative stuff like that I guess.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jul 18, 2017

Member

Updated, but for some reason i can't give experience to enemy actors at all even with Enemy on ValidStances:. I'll try to find out why.

Edit: Neutral works fine too, something is wrong with enemy.

Member

MustaphaTR commented Jul 18, 2017

Updated, but for some reason i can't give experience to enemy actors at all even with Enemy on ValidStances:. I'll try to find out why.

Edit: Neutral works fine too, something is wrong with enemy.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Jul 18, 2017

Member

Updated. Hopefully no problems left.

Member

MustaphaTR commented Jul 18, 2017

Updated. Hopefully no problems left.

@AndriiYukhymchak

This comment has been minimized.

Show comment
Hide comment
@AndriiYukhymchak

AndriiYukhymchak Jul 24, 2017

Contributor

Will they be able to get into helicopters/planes on the helipad/airfield?
Also, thanks for this feature

Contributor

AndriiYukhymchak commented Jul 24, 2017

Will they be able to get into helicopters/planes on the helipad/airfield?
Also, thanks for this feature

@Mailaender

Works as promised.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Sep 11, 2017

Member

@MustaphaTR can you remove the testcase now?

Member

abcdefg30 commented Sep 11, 2017

@MustaphaTR can you remove the testcase now?

@MustaphaTR MustaphaTR dismissed stale reviews from Mailaender and abcdefg30 via 25fccfd Sep 12, 2017

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Sep 12, 2017

Member

Removed the testcase.

Member

MustaphaTR commented Sep 12, 2017

Removed the testcase.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Sep 14, 2017

Member

Updated.

Member

MustaphaTR commented Sep 14, 2017

Updated.

@abcdefg30 abcdefg30 merged commit c0b8bb3 into OpenRA:bleed Sep 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Sep 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment