New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Mobile.OnRails hack with dedicated OnRails traits #13635

Merged
merged 4 commits into from Jul 23, 2017

Conversation

Projects
None yet
5 participants
@reaperrr
Contributor

reaperrr commented Jul 14, 2017

While the new OnRails and AttackOnRailsTurreted are essentially hacky as well,

  • they don't meddle with Common code (literally)
  • they work better, because on bleed the gunboat often stops for a few ticks when attacking, while with this PR it works just like in the original game
  • they allow to remove waypoints and lua triggers from some TD missions

Additionally, used this opportunity to replace the hacky camera actors in those missions with adjusted RevealsShroud.ValidStances.

@abcdefg30

Looks good to me otherwise. 👍

Show outdated Hide outdated OpenRA.Mods.Cnc/Traits/OnRails.cs
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jul 14, 2017

Contributor

Updated. Fixed upgrade rule comment, removed regions, added DamageState-based slowdown to TD Gunboat (they're singleplayer only, so it shouldn't matter if it makes them a little easier to kill).

Contributor

reaperrr commented Jul 14, 2017

Updated. Fixed upgrade rule comment, removed regions, added DamageState-based slowdown to TD Gunboat (they're singleplayer only, so it shouldn't matter if it makes them a little easier to kill).

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jul 20, 2017

Contributor

Updated.

Contributor

reaperrr commented Jul 20, 2017

Updated.

@obrakmann

This comment has been minimized.

Show comment
Hide comment
@obrakmann

obrakmann Jul 23, 2017

Contributor

👍

Contributor

obrakmann commented Jul 23, 2017

👍

@obrakmann obrakmann merged commit 8403adb into OpenRA:bleed Jul 23, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@obrakmann

This comment has been minimized.

Show comment
Hide comment
@obrakmann
Contributor

obrakmann commented Jul 23, 2017

@reaperrr reaperrr deleted the reaperrr:remove-OnRailsHack branch Nov 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment