New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework harvester resource claiming #13646

Merged
merged 1 commit into from Jul 17, 2017

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Jul 15, 2017

This aims to introduce a small island of sanity into the crazy mess of the harvesting code.
Supersedes #13607, fixing the dead-actor and enemy-actor reservation issues.

Rework harvester resource claiming:
 * Maintains lists of claims, and only restricts
   reservations for friendly units.
 * Removes OnNotifyResourceClaimLost; it's not
   clear whether that is still useful, and it
   prevents future necessary cleanups.
 * Moves other code without changing behaviour.

This fixed stale claims from dead units and enemy
claims from preventing otherwise valid harvest
activities.
@abcdefg30

Didn't spot any obvious issues and this fixes the same bug #13607 did fix.

@reaperrr

Looks good as far as I can tell and spotted no issues during a 4vs4 AI game

@reaperrr reaperrr merged commit afd8b9a into OpenRA:bleed Jul 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:resource-claim branch Oct 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment