New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BurstDelay to BurstDelays, supporting per-burst delays #13684

Merged
merged 6 commits into from Aug 20, 2017

Conversation

Projects
None yet
3 participants
@reaperrr
Contributor

reaperrr commented Jul 22, 2017

Closes #13683.

Depends on #13597.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jul 29, 2017

Contributor

Rebased.

Contributor

reaperrr commented Jul 29, 2017

Rebased.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Aug 17, 2017

Contributor

Rebased.

Contributor

reaperrr commented Aug 17, 2017

Rebased.

@pchote

pchote approved these changes Aug 17, 2017

@pchote pchote added the PR: Needs +2 label Aug 17, 2017

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Aug 18, 2017

Contributor

Updated.

Contributor

reaperrr commented Aug 18, 2017

Updated.

@rob-v

rob-v approved these changes Aug 18, 2017

👍

Show outdated Hide outdated OpenRA.Mods.Common/UtilityCommands/UpgradeRules.cs Outdated

reaperrr added some commits Jul 16, 2017

Refactor BurstDelay to BurstDelays
Allowing to set custom per-burst delays.
Tweak TS Juggernaut BurstDelays and Report
Since the original sound contains 3 shots, it could happen that the sound played even though only 1 shot had been fired.
Additionally, it could happen that no sound was played when shooting because the first burst had already been fired.
Finally, in the original the 3rd shot was delayed a little compared to the first two.

This adresses all these issues.

@reaperrr reaperrr merged commit a4ef199 into OpenRA:bleed Aug 20, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@pchote pchote referenced this pull request Jun 3, 2018

Merged

Add more update rules #15010

@reaperrr reaperrr deleted the reaperrr:varyingBurstDelays branch Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment