New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the exception message when a Bridge's DemolishWeapon cannot be found #13691

Merged
merged 1 commit into from Jul 29, 2017

Conversation

Projects
None yet
4 participants
@Phrohdoh
Member

Phrohdoh commented Jul 22, 2017

Closes #13690

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jul 22, 2017

Member

Fixing these crashes on a piecemeal basis kind of sucks. Would you mind doing a quick audit of Ruleset.Weapons usage and make sure that we have similar checks for all these *Info cases?

We should at least have them documented even if you don't fix them all here.

Member

pchote commented Jul 22, 2017

Fixing these crashes on a piecemeal basis kind of sucks. Would you mind doing a quick audit of Ruleset.Weapons usage and make sure that we have similar checks for all these *Info cases?

We should at least have them documented even if you don't fix them all here.

@pchote pchote added this to the Next Release milestone Jul 22, 2017

@Phrohdoh

This comment has been minimized.

Show comment
Hide comment
@Phrohdoh

Phrohdoh Jul 22, 2017

Member

I have documented cases where we should make the same changes in #13692.

Member

Phrohdoh commented Jul 22, 2017

I have documented cases where we should make the same changes in #13692.

@Phrohdoh

This comment has been minimized.

Show comment
Hide comment
@Phrohdoh

Phrohdoh Jul 22, 2017

Member

@pchote I have updated the code. PTAL

Member

Phrohdoh commented Jul 22, 2017

@pchote I have updated the code. PTAL

@Phrohdoh

This comment has been minimized.

Show comment
Hide comment
@Phrohdoh

Phrohdoh Jul 23, 2017

Member

@rob-v I have updated the code.

Member

Phrohdoh commented Jul 23, 2017

@rob-v I have updated the code.

@rob-v

rob-v approved these changes Jul 23, 2017

👍

I noticed it is reported as: 'Actor type br1: A value for DemolishWeapon of br1's Bridge trait is missing.'
so you could remove ai.Name from message.

@Phrohdoh

This comment has been minimized.

Show comment
Hide comment
@Phrohdoh

Phrohdoh Jul 23, 2017

Member

@rob-v It is done, good catch.

Member

Phrohdoh commented Jul 23, 2017

@rob-v It is done, good catch.

@reaperrr reaperrr merged commit 57fb551 into OpenRA:bleed Jul 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Phrohdoh Phrohdoh deleted the Phrohdoh:bridge-weapon-exception branch Jul 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment