New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TargetWhenIdle and TargetWhenDamaged from AutoTarget #13695

Merged
merged 1 commit into from Aug 10, 2017

Conversation

Projects
None yet
4 participants
@abcdefg30
Member

abcdefg30 commented Jul 22, 2017

Those were just bogus/unnecessary and are now replaced by using InitialStance (and EnableStances: false).

@pchote pchote added this to the Next Release milestone Jul 22, 2017

@rob-v

Small suggestion, question.

Show outdated Hide outdated OpenRA.Mods.Common/UtilityCommands/UpgradeRules.cs
TargetWhenDamaged: false
EnableStances: false
InitialStance: HoldFire
InitialStanceAI: HoldFire

This comment has been minimized.

@rob-v

rob-v Jul 23, 2017

Contributor

According to UpgradeRules, isn't EnableStances: false missing here and below?

@rob-v

rob-v Jul 23, 2017

Contributor

According to UpgradeRules, isn't EnableStances: false missing here and below?

This comment has been minimized.

@abcdefg30

abcdefg30 Jul 23, 2017

Member

Yes, this is a manual adjustment as we actually want aircraft to have stances enabled. (I'd only need EnableStances: false to retain the old [bogus] behavior.)

@abcdefg30

abcdefg30 Jul 23, 2017

Member

Yes, this is a manual adjustment as we actually want aircraft to have stances enabled. (I'd only need EnableStances: false to retain the old [bogus] behavior.)

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Jul 23, 2017

Contributor

Needs rebase.

Contributor

reaperrr commented Jul 23, 2017

Needs rebase.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Aug 7, 2017

Member

Updated and rebased.

Member

abcdefg30 commented Aug 7, 2017

Updated and rebased.

@rob-v

rob-v approved these changes Aug 7, 2017 edited

One mistake in UpgradeRules, otherwise lgtm 👍 , though upgrade not tested.

@pchote

pchote approved these changes Aug 9, 2017

Looks fine otherwise

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Aug 10, 2017

Member

Updated.

Member

abcdefg30 commented Aug 10, 2017

Updated.

@reaperrr reaperrr merged commit de7a0c9 into OpenRA:bleed Aug 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:airStances branch Aug 10, 2017

@pchote pchote referenced this pull request Jun 3, 2018

Merged

Add more update rules #15010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment