New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MAD Tank command bar deploy. #13700

Merged
merged 2 commits into from Jul 23, 2017

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Jul 22, 2017

Fixes #13698 and the missing tooltip description.

@pchote pchote added this to the Next Release milestone Jul 22, 2017

@obrakmann

This comment has been minimized.

Show comment
Hide comment
@obrakmann

obrakmann Jul 23, 2017

Contributor

👍

Contributor

obrakmann commented Jul 23, 2017

👍

@rob-v

rob-v approved these changes Jul 23, 2017 edited

👍

side note: it would be better to have as convention a OrderName constant in traits for cleaner code. E.g. MadTank uses "Detonate" string 4 times now.

@obrakmann

Whoops, need to approve properly. 👍

@obrakmann obrakmann merged commit 4c222e5 into OpenRA:bleed Jul 23, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@obrakmann

This comment has been minimized.

Show comment
Hide comment
@obrakmann
Contributor

obrakmann commented Jul 23, 2017

@pchote pchote deleted the pchote:fix-qtnk-commandbar branch Oct 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment