New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Land activity to land mid air #13701

Merged
merged 1 commit into from Sep 24, 2017

Conversation

Projects
None yet
5 participants
@forcecore
Contributor

forcecore commented Jul 22, 2017

Land.cs, which is used by Enter.cs (from MoveIntoActor) expanded to support mid-air landing into "Carrier" actors.

@forcecore forcecore changed the title from Allows Land activity to land mid air to Allow Land activity to land mid air Jul 22, 2017

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Jul 23, 2017

Contributor

Updated to use plane.Info

Contributor

forcecore commented Jul 23, 2017

Updated to use plane.Info

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Aug 18, 2017

Member

Can you please squash the commits?

Member

pchote commented Aug 18, 2017

Can you please squash the commits?

Land activity now lets the actor to land midair
Midair, at the altitude of the target actor.
@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Aug 18, 2017

Contributor

Squashed

Contributor

forcecore commented Aug 18, 2017

Squashed

@RoosterDragon

👍

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Sep 24, 2017

Contributor

If I increase the RA airfield's Z position via Building.LocalCenterOffset, the aircraft seems to land but immediately takes off again. I assume things like carriers would have the same issue, @forcecore have you tested this?

Contributor

reaperrr commented Sep 24, 2017

If I increase the RA airfield's Z position via Building.LocalCenterOffset, the aircraft seems to land but immediately takes off again. I assume things like carriers would have the same issue, @forcecore have you tested this?

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Sep 24, 2017

Contributor

My carriers didn't have such issue, as they Enter the transport after landing.
Erm... LocalCenterOffset seems to be new

Contributor

forcecore commented Sep 24, 2017

My carriers didn't have such issue, as they Enter the transport after landing.
Erm... LocalCenterOffset seems to be new

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Sep 24, 2017

Contributor

My carriers didn't have such issue, as they Enter the transport after landing.
Erm... LocalCenterOffset seems to be new

OK. Yeah, LocalCenterOffset is pretty new.
I guess we can merge this first (since it doesn't affect the shipping mods) and then investigate the take-off issue as part of my aircraft activity-merging PRs.

Contributor

reaperrr commented Sep 24, 2017

My carriers didn't have such issue, as they Enter the transport after landing.
Erm... LocalCenterOffset seems to be new

OK. Yeah, LocalCenterOffset is pretty new.
I guess we can merge this first (since it doesn't affect the shipping mods) and then investigate the take-off issue as part of my aircraft activity-merging PRs.

@reaperrr reaperrr merged commit b86d632 into OpenRA:bleed Sep 24, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Sep 24, 2017

Contributor

My current guess is plane.Info.LandHeight : actors at this height will be considered landing and this might need change too.

Contributor

forcecore commented Sep 24, 2017

My current guess is plane.Info.LandHeight : actors at this height will be considered landing and this might need change too.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Sep 24, 2017

Contributor

The problem lies in the Aircraft.GetActorBelow() method, it always returns null if the target actor's distance above terrain is not 0.

Simply removing that check from GetActorBelow should be enough to fix this.

Contributor

reaperrr commented Sep 24, 2017

The problem lies in the Aircraft.GetActorBelow() method, it always returns null if the target actor's distance above terrain is not 0.

Simply removing that check from GetActorBelow should be enough to fix this.

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Sep 24, 2017

Contributor

Somewhere in my MultiDock PR, I think I removed GetActorBelow hacks. Maybe not all of them though.

Contributor

forcecore commented Sep 24, 2017

Somewhere in my MultiDock PR, I think I removed GetActorBelow hacks. Maybe not all of them though.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Sep 24, 2017

Contributor

Somewhere in my MultiDock PR, I think I removed GetActorBelow hacks.

OK.

changelog

Contributor

reaperrr commented Sep 24, 2017

Somewhere in my MultiDock PR, I think I removed GetActorBelow hacks.

OK.

changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment