New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yuri Grinder support using DonateCash #13717

Merged
merged 1 commit into from Oct 6, 2017

Conversation

Projects
None yet
5 participants
@forcecore
Contributor

forcecore commented Jul 24, 2017

This PR adds support for animation and sound for DonateCash, fulfilling the requirement for Yuri Grinder.
With the implementation of Type filter for DonateCash a while ago, only a little extension was needed, and here it is.

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Aug 15, 2017

Contributor

Changed

Contributor

forcecore commented Aug 15, 2017

Changed

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Aug 18, 2017

Contributor

Rebased, squashed, variable renamed.

Contributor

forcecore commented Aug 18, 2017

Rebased, squashed, variable renamed.

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Aug 25, 2017

Contributor

I noticed that WithAcceptDeliveredCashAnimation.cs wouldn't work with multiple WSBs. Fixed.

Contributor

forcecore commented Aug 25, 2017

I noticed that WithAcceptDeliveredCashAnimation.cs wouldn't work with multiple WSBs. Fixed.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Sep 11, 2017

Member

Needs a rebase.

Member

abcdefg30 commented Sep 11, 2017

Needs a rebase.

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Sep 15, 2017

Contributor

Rebased

Contributor

forcecore commented Sep 15, 2017

Rebased

@abcdefg30

Looks good to me otherwise. 👍 /

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Sep 19, 2017

Contributor

Removed IsDisabled().

Contributor

forcecore commented Sep 19, 2017

Removed IsDisabled().

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Oct 1, 2017

Contributor

Addressed two more review comments, rebased.

Contributor

forcecore commented Oct 1, 2017

Addressed two more review comments, rebased.

@reaperrr reaperrr merged commit 18c6fe0 into OpenRA:bleed Oct 6, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@forcecore forcecore deleted the forcecore:Grinder branch Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment