New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD GrantConditionOnAttack Trait #13736

Merged
merged 1 commit into from Nov 4, 2017

Conversation

Projects
None yet
6 participants
@forcecore
Contributor

forcecore commented Jul 27, 2017

Useful for making Gattling weapons (Yuri's Revenge and C&C Generals) or Boris (RA2) / Natasha (RA3) call for airstrike.

Demo: https://www.youtube.com/watch?v=fQn0rspPH3s

@forcecore forcecore changed the title from ADD GrantStackableConditionOnFire Trait to ADD GrantConditionOnAttack Trait Aug 14, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Aug 17, 2017

Member

Can you please provide a simple testcase for this on top of one of the default mods?

Member

pchote commented Aug 17, 2017

Can you please provide a simple testcase for this on top of one of the default mods?

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach Aug 17, 2017

Contributor

I can vouch that this works wonderfully in AS, been using it for Black Lotus's building-capture for weeks now.

Contributor

GraionDilach commented Aug 17, 2017

I can vouch that this works wonderfully in AS, been using it for Black Lotus's building-capture for weeks now.

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Aug 18, 2017

Contributor

I've added an example mod. JEEP will shoot m60 --> Vulcan --> ChainGun.

Contributor

forcecore commented Aug 18, 2017

I've added an example mod. JEEP will shoot m60 --> Vulcan --> ChainGun.

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Aug 23, 2017

Contributor

Renamed some parameters in Info.

Contributor

forcecore commented Aug 23, 2017

Renamed some parameters in Info.

@Mailaender Mailaender referenced this pull request Aug 24, 2017

Open

Added GI sandbag deployment #394

1 of 3 tasks complete
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Aug 31, 2017

Contributor

Looks good to me otherwise. I think you can remove the test commit, but maybe you could still keep and link here a separate branch with the testcase, if anyone else wants to test this before (or after) this is merged.

Contributor

reaperrr commented Aug 31, 2017

Looks good to me otherwise. I think you can remove the test commit, but maybe you could still keep and link here a separate branch with the testcase, if anyone else wants to test this before (or after) this is merged.

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Sep 6, 2017

Contributor

Updated, squashed, rebased and example mod removed.

If you need the example gattling JEEP mod, unzip this:
gatt.zip

Contributor

forcecore commented Sep 6, 2017

Updated, squashed, rebased and example mod removed.

If you need the example gattling JEEP mod, unzip this:
gatt.zip

@pchote

I haven't tested this yet, but the basic approach looks good. Just a couple of minor code nits and then I anticipate being able to 👍 and merge.

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Sep 6, 2017

Contributor

Fixed and rebased

Contributor

forcecore commented Sep 6, 2017

Fixed and rebased

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender

Mailaender Sep 10, 2017

Member

This does work. I rebased my #13946 for a convenient test case.

Member

Mailaender commented Sep 10, 2017

This does work. I rebased my #13946 for a convenient test case.

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Sep 15, 2017

Contributor

Rebased. The default armament name is primary now.

Contributor

forcecore commented Sep 15, 2017

Rebased. The default armament name is primary now.

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Sep 17, 2017

Contributor

Done more fixes

Contributor

forcecore commented Sep 17, 2017

Done more fixes

ADD GrantConditionOnAttack Trait
Useful for making Gattling weapons (Yuri's Revenge and C&C Generals) or
Boris (RA2) / Natasha (RA3) call for airstrike.
@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Oct 29, 2017

Contributor

TraitOrDefault for ConditionManager and null check

Contributor

forcecore commented Oct 29, 2017

TraitOrDefault for ConditionManager and null check

@pchote pchote dismissed their stale review Oct 29, 2017

Code updated

@abcdefg30 abcdefg30 merged commit 4c78a05 into OpenRA:bleed Nov 4, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Nov 4, 2017

@forcecore forcecore deleted the forcecore:GrantConditionOnFire branch Jan 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment