New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Client tooltip crash in Lobby #13757

Merged
merged 1 commit into from Aug 9, 2017

Conversation

Projects
None yet
4 participants
@rob-v
Contributor

rob-v commented Jul 31, 2017

Fixes #13731

As I checked the combination I changed it to widget.IsVisible() + tooltipContainer.BeforeRender in #13365 is standard. It failed on line if (admin.IsVisible()). I tried to add the check to admin.IsVisible which avoided the crash but the tooltip of disconnected player stayed visible until mouse move so I added the early return as suggested by @pchote in #13731 .

@rob-v rob-v referenced this pull request Jul 31, 2017

Closed

Playtest Crash #13731

@reaperrr reaperrr added this to the Next Release milestone Aug 5, 2017

@pchote

pchote approved these changes Aug 9, 2017

Fix confirmed

@pchote pchote merged commit 88a3656 into OpenRA:bleed Aug 9, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment