New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RA Aftermath installer metadata on Linux #13760

Merged
merged 1 commit into from Aug 2, 2017

Conversation

Projects
None yet
3 participants
@extmind
Contributor

extmind commented Aug 2, 2017

This fixes the installation of RA Aftermath files from disk on Linux, which was broken because of filename case-sensitivity.

@pchote

pchote approved these changes Aug 2, 2017

Oops, nice catch!

Note: I haven't tested this, but it is obviously correct (compare with the IDFiles entry).

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Aug 2, 2017

Member

Some background:

The problem is a bit more complicated than just case sensitivity. CDs/ISOs require filenames to be in uppercase 8.3 format. The default behaviour on Linux is to force all filenames to lower case, but some people/distros mount them with a flag that preserves the original upper-case names. Some discs can also have an extra extension table that defines the specific case-sensitive names, which may or may not be parsed by the system.

The only robust way to support all systems is to look for/accept both upper and lower case paths.

Member

pchote commented Aug 2, 2017

Some background:

The problem is a bit more complicated than just case sensitivity. CDs/ISOs require filenames to be in uppercase 8.3 format. The default behaviour on Linux is to force all filenames to lower case, but some people/distros mount them with a flag that preserves the original upper-case names. Some discs can also have an extra extension table that defines the specific case-sensitive names, which may or may not be parsed by the system.

The only robust way to support all systems is to look for/accept both upper and lower case paths.

@abcdefg30 abcdefg30 merged commit 6860787 into OpenRA:bleed Aug 2, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Aug 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment