New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform FogObscures check as late as possible #13777

Merged
merged 1 commit into from Aug 7, 2017

Conversation

Projects
None yet
3 participants
@reaperrr
Contributor

reaperrr commented Aug 5, 2017

FogObscures is usually much more expensive than simpler boolean, viewing player or HasTraitInfo checks, so in these places it makes sense to perform the other checks first to avoid FogObscures altogether, if possible.

Perform FogObscures as late as possible
FogObscures is more expensive than simpler boolean, player or HasTraitInfo checks, so in these places it makes sense to perform the other checks first.
@rob-v

rob-v approved these changes Aug 6, 2017

👍

@abcdefg30 abcdefg30 merged commit d949e17 into OpenRA:bleed Aug 7, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Aug 7, 2017

@reaperrr reaperrr deleted the reaperrr:optimizeFogObsChecks branch Nov 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment