Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Statistics options hotkeys #13781
referenced this pull request
Sep 10, 2017
Looks good overall, just two minor points (of which one is my fault) and a scope creep:
This feature would be much more useful if the tab hotkeys worked directly from the world without opening the panel first. It shouldn't be too hard to adapt:
to open from any of the keys by following the approach of:
Looks good, thanks. Just two more minor nits, and then can you also change the
Key:'s to use
StatisticsBasic instead of hardcoding
Updated. All good ideas. Now much more useful to use hotkeys ingame to open directly a stats tab, though it is little annoying (discouraging to use) that it takes second(s) (since latest playtests) to open a/Stats dialog.
Re OBSERVER_STATS_BUTTON's Key - I removed it, as StatisticsBasicKey already works without this now. Is it ok or you prefer to keep it?
What do you mean? Is this a recent regression?
Keep it please so that it will show the hotkey in the tooltip.