New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sound on command bar buttons #13782

Merged
merged 2 commits into from Aug 9, 2017

Conversation

Projects
None yet
3 participants
@rob-v
Contributor

rob-v commented Aug 6, 2017

Closes #13730

Add new ButtonWidget.PlaySoundOnKeyPress property and apply it (PlaySoundOnKeyPress: false) on command bar buttons to remove sound on key press.

@rob-v

This comment has been minimized.

Show comment
Hide comment
@rob-v

rob-v Aug 9, 2017

Contributor

@pchote If players don't like sound on hotkey (and it happens only for hotkeys with appropriate button on screen, not all) and iirc, it is not standard for 'click sound' on key press in other games I propose to remove the 'click sound' for all buttons on key press. Or we could change the default to false and only add new PlaySoundOnKeyPress: true where really wanted.

Contributor

rob-v commented Aug 9, 2017

@pchote If players don't like sound on hotkey (and it happens only for hotkeys with appropriate button on screen, not all) and iirc, it is not standard for 'click sound' on key press in other games I propose to remove the 'click sound' for all buttons on key press. Or we could change the default to false and only add new PlaySoundOnKeyPress: true where really wanted.

@pchote

pchote approved these changes Aug 9, 2017

👍 to this approach. Just an open question about the flag name.

I originally tried to prototype a fix for this using separate ClickSound / KeyPressClickSound fields on the ButtonWidget, but ran into problems with having our FieldLoader code behave in the way I wanted with null vs string.Empty. The approach here is much simpler.

@rob-v

This comment has been minimized.

Show comment
Hide comment
@rob-v

rob-v Aug 9, 2017

Contributor

Updated - PlaySoundOnKeyPress renamed to DisableKeySound.

Contributor

rob-v commented Aug 9, 2017

Updated - PlaySoundOnKeyPress renamed to DisableKeySound.

@pchote

pchote approved these changes Aug 9, 2017

@pchote pchote merged commit 86cff9a into OpenRA:bleed Aug 9, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote referenced this pull request Aug 10, 2017

Merged

Add command bar to TS #13802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment