Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Disable sound on command bar buttons #13782
referenced this pull request
Aug 6, 2017
@pchote If players don't like sound on hotkey (and it happens only for hotkeys with appropriate button on screen, not all) and iirc, it is not standard for 'click sound' on key press in other games I propose to remove the 'click sound' for all buttons on key press. Or we could change the default to false and only add new PlaySoundOnKeyPress: true where really wanted.
I originally tried to prototype a fix for this using separate
KeyPressClickSound fields on the
ButtonWidget, but ran into problems with having our
FieldLoader code behave in the way I wanted with
string.Empty. The approach here is much simpler.