New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't spawn new actors (using SpawnActorOnDeath) before all RemovedFromWorld callbacks have run #13796

Merged
merged 1 commit into from Aug 10, 2017

Conversation

Projects
None yet
3 participants
@abcdefg30
Member

abcdefg30 commented Aug 8, 2017

Fixes #13694.

Testcase: #13694 (comment)

@abcdefg30 abcdefg30 added this to the Next Release milestone Aug 8, 2017

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Aug 8, 2017

Member

Updated as discussed on IRC. INotifyKilled has been removed from Building and SpawnActorOnDeath waits for all other RemovedFromWorld calls before spawning the new actor now instead.

Member

abcdefg30 commented Aug 8, 2017

Updated as discussed on IRC. INotifyKilled has been removed from Building and SpawnActorOnDeath waits for all other RemovedFromWorld calls before spawning the new actor now instead.

@abcdefg30 abcdefg30 changed the title from Rework the addition and removal of building influence to Don't spawn new actors (using SpawnActorOnDeath) before all RemovedFromWorld callbacks have run Aug 8, 2017

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Aug 8, 2017

Member

Dropped the first commit as suggested on IRC.

Member

abcdefg30 commented Aug 8, 2017

Dropped the first commit as suggested on IRC.

@pchote

pchote approved these changes Aug 9, 2017

@pchote pchote added the PR: Needs +2 label Aug 9, 2017

@reaperrr reaperrr merged commit d1ab421 into OpenRA:bleed Aug 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:influence branch Aug 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment