New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the description of LandOnCondition of Aircraft #13811

Merged
merged 1 commit into from Aug 11, 2017

Conversation

Projects
None yet
4 participants
@jrb0001
Contributor

jrb0001 commented Aug 9, 2017

This addresses the feedback from @pchote after #13434 was merged.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Aug 10, 2017

Member

OpenRA.Mods.Common/Traits/Air/Aircraft.cs:L104: [SP2100] Code line must be no longer than 180 characters (now 197).

Member

abcdefg30 commented Aug 10, 2017

OpenRA.Mods.Common/Traits/Air/Aircraft.cs:L104: [SP2100] Code line must be no longer than 180 characters (now 197).

@jrb0001

This comment has been minimized.

Show comment
Hide comment
@jrb0001

jrb0001 Aug 10, 2017

Contributor

Fixed.

Contributor

jrb0001 commented Aug 10, 2017

Fixed.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Aug 10, 2017

Member

It looks like nothing changed...?

Member

abcdefg30 commented Aug 10, 2017

It looks like nothing changed...?

@jrb0001

This comment has been minimized.

Show comment
Hide comment
@jrb0001

jrb0001 Aug 10, 2017

Contributor

Forgot to add the file, it seems.

Contributor

jrb0001 commented Aug 10, 2017

Forgot to add the file, it seems.

@atlimit8 atlimit8 merged commit 49f4240 into OpenRA:bleed Aug 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jrb0001 jrb0001 deleted the jrb0001:landoncondition branch Aug 11, 2017

@atlimit8

This comment has been minimized.

Show comment
Hide comment
@atlimit8
Member

atlimit8 commented Aug 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment