New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus the ViewportController on Standard/Inverted scroll modes. #13812

Merged
merged 1 commit into from Aug 10, 2017

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Aug 9, 2017

Fixes #13727 and makes sure that scrolling remains active when the cursor moves over other interface elements (as it already does for Joystick scrolling).

@pchote pchote added this to the Next Release milestone Aug 9, 2017

@pchote pchote requested a review from rob-v Aug 9, 2017

@rob-v

rob-v approved these changes Aug 9, 2017 edited

It is hard to say with all these events, options, but it makes sense, is consistent with Joystick scrolling and mainly works fine ingame. It fixes the issue, but also changes behaviour, now scrolling continues as expected while above minimap with pressed MMB.

I noticed few issues not related to this PR, I found this way simpler to report them: rob-v@a727655
You can ignore them all.
It is to unify it with Joystick scrolling-else if, events in the same order, some unnecessary rows removed.

@pchote pchote added the PR: Needs +2 label Aug 9, 2017

@abcdefg30 abcdefg30 merged commit 22d7031 into OpenRA:bleed Aug 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Aug 10, 2017

@pchote pchote deleted the pchote:fix-scroll-focus branch Oct 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment