New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load replays also in sub directories #13818

Merged
merged 1 commit into from Aug 21, 2017

Conversation

Projects
None yet
3 participants
@rob-v
Contributor

rob-v commented Aug 10, 2017

Requested here #13809

It is simpler to copy/delete a folder with replays, extract a zip,.. into e.g. \Documents\OpenRA\Replays\ra\release-20170527 than having to copy all replays into 1 folder.
If wanted/supported we might add a new filter option - folder selection to restrict the filter for select folder (e.g. a tournament, ...).

@pchote

pchote approved these changes Aug 17, 2017

Looks fine to me.

If somebody is dumb enough to create a symlink to a higher directory then the game will infinitely recurse the structure, but that's a user problem not a game problem.

@pchote pchote added the PR: Needs +2 label Aug 17, 2017

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Aug 21, 2017

Member

👍

Member

abcdefg30 commented Aug 21, 2017

👍

@abcdefg30 abcdefg30 merged commit 01d631b into OpenRA:bleed Aug 21, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment