New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping sell/undeploy anim #13822

Merged
merged 3 commits into from Aug 17, 2017

Conversation

Projects
None yet
5 participants
@reaperrr
Contributor

reaperrr commented Aug 10, 2017

At least in TransformOnCapture and Sellable.

Closes #13688.
Closes #13704.

@reaperrr reaperrr added this to the Next Release milestone Aug 10, 2017

@obrakmann

lgtm, 👍

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Aug 13, 2017

Contributor

Updated.

Contributor

reaperrr commented Aug 13, 2017

Updated.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Aug 13, 2017

Contributor

Updated.

Contributor

reaperrr commented Aug 13, 2017

Updated.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Aug 14, 2017

Member

While you are in it, can we get a SkipMakeAnimation for GrantConditionOnDeploy. That could fix #13704, i'm having similar problem with Chinese Nuke Reactors (Overcharge) too.

Member

MustaphaTR commented Aug 14, 2017

While you are in it, can we get a SkipMakeAnimation for GrantConditionOnDeploy. That could fix #13704, i'm having similar problem with Chinese Nuke Reactors (Overcharge) too.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Aug 17, 2017

Member

@MustaphaTR: Good point. IMO that is a more serious problem than the cases here because modders are more likely to use GrantConditionOnDeploy than TransformOnCapture or custom sell behavior.

Member

pchote commented Aug 17, 2017

@MustaphaTR: Good point. IMO that is a more serious problem than the cases here because modders are more likely to use GrantConditionOnDeploy than TransformOnCapture or custom sell behavior.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Aug 17, 2017

Contributor

Updated.

Contributor

reaperrr commented Aug 17, 2017

Updated.

@pchote

pchote approved these changes Aug 17, 2017

@pchote pchote merged commit cab6a96 into OpenRA:bleed Aug 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reaperrr reaperrr deleted the reaperrr:allowMakeSkip branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment