Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BeaconLib to 1.0.1. #13824

Merged
merged 2 commits into from Aug 13, 2017
Merged

Update BeaconLib to 1.0.1. #13824

merged 2 commits into from Aug 13, 2017

Conversation

pchote
Copy link
Member

@pchote pchote commented Aug 10, 2017

Closes #13674.

@pchote pchote added this to the Next Release milestone Aug 10, 2017
@pchote pchote mentioned this pull request Aug 10, 2017
Closed
rob-v
rob-v approved these changes Aug 10, 2017
View reviewed changes
Copy link
Contributor

@rob-v rob-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

no practical reason? but it could be updated also here:
https://github.com/OpenRA/OpenRA/blob/bleed/OpenRA.Mods.Common/OpenRA.Mods.Common.csproj#L44

@reaperrr
Copy link
Contributor

reaperrr commented Aug 13, 2017 •
edited

from IRC:

[16:34] <+pchote> the specific version stuff should be removed

Best to do that with this PR so we don't have to file another one, in my opinion.

@pchote
Copy link
Member Author

pchote commented Aug 13, 2017

Done.

obrakmann
obrakmann approved these changes Aug 13, 2017
View reviewed changes
Copy link
Contributor

@obrakmann obrakmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@obrakmann obrakmann merged commit 62a006e into OpenRA:bleed Aug 13, 2017
@obrakmann
Copy link
Contributor

Changelog

@pchote pchote deleted the update-beaconlib branch October 15, 2017 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obrakmann obrakmann obrakmann approved these changes

@rob-v rob-v rob-v approved these changes

Assignees
No one assigned
Labels
PR: For stable PR: Needs +2
Projects
None yet
Milestone
Release 20171014
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pchote @reaperrr @obrakmann @rob-v @abcdefg30