New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to .NET 4.5 compatible Marshal.SizeOf overload. #13833

Merged
merged 1 commit into from Aug 13, 2017

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Aug 12, 2017

Fixes #13747.

Fix confirmed by @AoAGeneral:

What I did instead was replaced the existing client in the actual folder itself with the one pchote has. Once I did that it worked with both versions 4.5 and 4.6.2.

Credit to @rob-v for identifying the cause of the crash.

@pchote pchote added this to the Next Release milestone Aug 12, 2017

@rob-v

rob-v approved these changes Aug 12, 2017

👍

@pchote pchote added the PR: Needs +2 label Aug 12, 2017

@abcdefg30 abcdefg30 merged commit b937bf4 into OpenRA:bleed Aug 13, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Aug 13, 2017

@pchote pchote deleted the pchote:dotnet-launcher branch Oct 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment