New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RequiresCondition to ProvidesPrerequisite #13842

Merged
merged 1 commit into from Sep 24, 2017

Conversation

Projects
None yet
6 participants
@jrb0001
Contributor

jrb0001 commented Aug 13, 2017

No description provided.

@jrb0001

This comment has been minimized.

Show comment
Hide comment
@jrb0001

jrb0001 Aug 19, 2017

Contributor

Fixed and rebased.

Contributor

jrb0001 commented Aug 19, 2017

Fixed and rebased.

@rob-v

rob-v approved these changes Aug 19, 2017

👍
@abcdefg30 please review again, there were changes

@pchote

This LGTM functionally. Just one easy to fix style nit and then we're good to go:

@jrb0001 jrb0001 dismissed stale reviews from pchote and abcdefg30 via 3a03232 Sep 24, 2017

@jrb0001

This comment has been minimized.

Show comment
Hide comment
@jrb0001

jrb0001 Sep 24, 2017

Contributor

rebased.

Contributor

jrb0001 commented Sep 24, 2017

rebased.

@pchote

pchote approved these changes Sep 24, 2017

@pchote pchote merged commit 2b96c2e into OpenRA:bleed Sep 24, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jrb0001 jrb0001 deleted the jrb0001:prerequisitecondition-bleed branch Sep 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment