New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bomber John map cleanup #13845

Merged
merged 3 commits into from Sep 13, 2017

Conversation

Projects
None yet
4 participants
@abcdefg30
Member

abcdefg30 commented Aug 13, 2017

First step towards reworking this minigame.

This PR additionally adds support for disabling adjacency on the Building trait.

@Phrohdoh

This comment has been minimized.

Show comment
Hide comment
@Phrohdoh

Phrohdoh Aug 28, 2017

Member

This PR additionally adds support for disabling adjacency on the Building trait.

That sounds like it should be in a separate PR.

Member

Phrohdoh commented Aug 28, 2017

This PR additionally adds support for disabling adjacency on the Building trait.

That sounds like it should be in a separate PR.

@Mailaender

👍 on the map cleanup.

abcdefg30 added some commits Aug 13, 2017

Bomber John sequence cleanup
Most of those sequences were unused or default values
Tick count fixed as well
Bomber John rules cleanup
Removed hacks, default values and duplicates
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Sep 12, 2017

Member

Rebased & updated.

Member

abcdefg30 commented Sep 12, 2017

Rebased & updated.

@reaperrr reaperrr merged commit 5ddf28f into OpenRA:bleed Sep 13, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Sep 13, 2017

@abcdefg30 abcdefg30 deleted the abcdefg30:bomber branch Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment