New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the Tiberian Sun repair pad crane animation #13940

Merged
merged 1 commit into from Sep 24, 2017

Conversation

Projects
None yet
4 participants
@Mailaender
Member

Mailaender commented Aug 30, 2017

Closes #9955.

@SoScared

This comment has been minimized.

Show comment
Hide comment
@SoScared

SoScared Sep 2, 2017

Member

Seem like the crane animation ought to play a little faster. It's a bit out of sync with the pace of the overall game animation.

Member

SoScared commented Sep 2, 2017

Seem like the crane animation ought to play a little faster. It's a bit out of sync with the pace of the overall game animation.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Sep 3, 2017

Member

The animation will freeze if you order the unit off the pad mid-repair.

Member

pchote commented Sep 3, 2017

The animation will freeze if you order the unit off the pad mid-repair.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Sep 3, 2017

Member

I also agree with @SoScared's point about the animation being to slow.

Member

pchote commented Sep 3, 2017

I also agree with @SoScared's point about the animation being to slow.

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender

Mailaender Sep 3, 2017

Member

Rebased, renamed the interfaces, added an additional AfterRepair notification for canceling and set the sequence to run at 2x the speed now.

Member

Mailaender commented Sep 3, 2017

Rebased, renamed the interfaces, added an additional AfterRepair notification for canceling and set the sequence to run at 2x the speed now.

@SoScared

Looking good visually.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Sep 13, 2017

Member

Needs a rebase

Member

pchote commented Sep 13, 2017

Needs a rebase

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Sep 17, 2017

Member
Exception of type `System.InvalidOperationException`: Attempted to get trait from destroyed object (gadept 163 (not in world))
  at OpenRA.TraitDictionary.CheckDestroyed (OpenRA.Actor actor) [0x00020] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.TraitDictionary.WithInterface[T] (OpenRA.Actor actor) [0x00001] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Actor.TraitsImplementing[T] () [0x00001] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Mods.Common.Activities.Repair.OnLastRun (OpenRA.Actor self) [0x00010] in <9dab9469a6c44130ba43a10586d6d880>:0 
  at OpenRA.Activities.Activity.TickOuter (OpenRA.Actor self) [0x000b7] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Traits.ActivityUtils.RunActivity (OpenRA.Actor self, OpenRA.Activities.Activity act) [0x00022] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Actor.Tick () [0x00010] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.World.Tick () [0x000c1] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Game.InnerLogicTick (OpenRA.Network.OrderManager orderManager) [0x0020a] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Game.LogicTick () [0x00050] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Game.Loop () [0x000d6] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Game.Run () [0x00042] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Program.Run (System.String[] args) [0x00011] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Program.Main (System.String[] args) [0x0004f] in <c388502d40e249d5a1922784eaccc7e1>:0 

Member

pchote commented Sep 17, 2017

Exception of type `System.InvalidOperationException`: Attempted to get trait from destroyed object (gadept 163 (not in world))
  at OpenRA.TraitDictionary.CheckDestroyed (OpenRA.Actor actor) [0x00020] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.TraitDictionary.WithInterface[T] (OpenRA.Actor actor) [0x00001] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Actor.TraitsImplementing[T] () [0x00001] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Mods.Common.Activities.Repair.OnLastRun (OpenRA.Actor self) [0x00010] in <9dab9469a6c44130ba43a10586d6d880>:0 
  at OpenRA.Activities.Activity.TickOuter (OpenRA.Actor self) [0x000b7] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Traits.ActivityUtils.RunActivity (OpenRA.Actor self, OpenRA.Activities.Activity act) [0x00022] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Actor.Tick () [0x00010] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.World.Tick () [0x000c1] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Game.InnerLogicTick (OpenRA.Network.OrderManager orderManager) [0x0020a] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Game.LogicTick () [0x00050] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Game.Loop () [0x000d6] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Game.Run () [0x00042] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Program.Run (System.String[] args) [0x00011] in <c388502d40e249d5a1922784eaccc7e1>:0 
  at OpenRA.Program.Main (System.String[] args) [0x0004f] in <c388502d40e249d5a1922784eaccc7e1>:0 

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender

Mailaender Sep 17, 2017

Member

Added IsDead checks as a countermeasure.

Member

Mailaender commented Sep 17, 2017

Added IsDead checks as a countermeasure.

@pchote

pchote approved these changes Sep 24, 2017

@pchote pchote merged commit 0018bf3 into OpenRA:bleed Sep 24, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Mailaender Mailaender deleted the Mailaender:repair-overlay-polish branch Sep 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment