New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WithShadow and enable it on airborne TS JumpJet #13952

Merged
merged 2 commits into from Aug 31, 2017

Conversation

Projects
None yet
4 participants
@reaperrr
Contributor

reaperrr commented Aug 31, 2017

WithShadow's behaviour when disabled was bogus, making the whole actor invisible.

Fixed that and enabled it on TS JumpJet infantry when airborne.

reaperrr added some commits Aug 31, 2017

Fix WithShadow
It *modifies* the actor rendering, so returning an empty renderable was bogus, as were the IsInWorld/IsDead checks.

@reaperrr reaperrr added this to the Tiberian Sun Public Alpha milestone Aug 31, 2017

@Mailaender Mailaender merged commit 93f385e into OpenRA:bleed Aug 31, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender
Member

Mailaender commented Aug 31, 2017

@reaperrr reaperrr deleted the reaperrr:with-shadow-jj branch Nov 11, 2017

@ABrandau

This comment has been minimized.

Show comment
Hide comment
@ABrandau

ABrandau Mar 21, 2018

Contributor

This is necropost but it works like a charm, thx.

Contributor

ABrandau commented Mar 21, 2018

This is necropost but it works like a charm, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment