New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed no explosions showing on some RA civ structures #13961

Merged
merged 1 commit into from Sep 2, 2017

Conversation

Projects
None yet
3 participants
@reaperrr
Contributor

reaperrr commented Sep 1, 2017

The combination of HitShape, but not Targetable makes the actors be considered invalid for effect warheads.
Lack of Targetable makes them invulnerable anyway, so removing HitShape and Health (and Explodes) is the most logical fix.

Fixes #13960.

Fixed no explosions showing on some RA civ structures
The combination of HitShape, but not Targetable makes the actors be considered invalid for effect warheads.
Lack of Targetable makes them invulnerable anyway, so removing HitShape and Health (and Explodes) is the most logical fix.

@reaperrr reaperrr added this to the Next Release milestone Sep 1, 2017

@FrameLimiter

LGTM 👍

@pchote

pchote approved these changes Sep 2, 2017

@pchote pchote merged commit 15c6365 into OpenRA:bleed Sep 2, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reaperrr reaperrr deleted the reaperrr:fix-more-effectWHs branch Nov 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment