Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Rework global and world hotkeys #13974
Hardcoding global hotkeys in the static order handling plumbing is fundamentally incompatible with the future mod-defined hotkey system: it is too low level to be exposed to mod code or to the linter. Fortunately we already have a pattern for mod-defined global hotkeys, as used by the music player.
This PR migrates the screenshot and mute (which previously only worked ingame) hotkeys to this new system, and removes the
works fine ingame, some issues outside (in scope of this PR?)
music keys: in lobby, editor, editor menu
screenshot: in editor, menus
mute: in editor
Re lobby keys not working: the lobby force-focuses the chat field which eats your input. If you switch to the map browser and back it will be unfocused and the global keys work.
Re editor keys not working: #11136 mistakenly added the key handler to the new map dialog only, and it wasn't caught during review (this was before we implemented the requirement for two