New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix water splashes on bridge in RA #13990

Merged
merged 2 commits into from Sep 10, 2017

Conversation

Projects
None yet
4 participants
@reaperrr
Contributor

reaperrr commented Sep 6, 2017

On bleed, both the explosion as well as the water splash warhead of weapons triggered on bridges, since they have both the Ground and Water target types.

Ground cannot be made invalid for water splashes without causing regressions elsewhere, so a new Bridge target type is introduced to explicitly make bridges invalid targets for water splash effect warheads.

Fixes #13989.

Fix water splash on bridge in RA
On bleed, both the explosion as well as the water splash warhead of weapons triggered on bridges, since they have both the Ground and Water target types.

Ground cannot be made invalid for water splashes without causing regressions elsewhere, so a new Bridge target type is introduced to explicitly make bridges invalid targets for water splash effect warheads.

@reaperrr reaperrr added this to the Next Release milestone Sep 6, 2017

@reaperrr reaperrr changed the title from Fix water splash on bridge in RA to Fix water splashes on bridge in RA Sep 6, 2017

@FrameLimiter

The Submarine's TorpTube CreateEffect isn't functioning vs bridges.

-All other weapons & explosions look good. 👍

Fix RA TorpTube bridge explosions
There were two issues at work here:
1) The combination of default MaximumLaunchAngle and default CruiseAltitude made torpedoes fly a ballistic curve, which combined with BoundToTerrain type made them explode 'in the air' when hitting non-water tiles. This would result in AIr returned as target type, which is invalid for torpedoes.
2) The explosion warheads were missing the Ground target type, which is actually the (only) target type that the bridge tiles you hit with torpedoes have.
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Sep 9, 2017

Contributor

Updated, fixed TorpTube. See commit desc for details.

Contributor

reaperrr commented Sep 9, 2017

Updated, fixed TorpTube. See commit desc for details.

@obrakmann

lgtm, 👍

@obrakmann obrakmann merged commit 0161d68 into OpenRA:bleed Sep 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@obrakmann

This comment has been minimized.

Show comment
Hide comment
@obrakmann
Contributor

obrakmann commented Sep 10, 2017

@reaperrr reaperrr deleted the reaperrr:fix-bridge-splash branch Nov 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment