New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use noget in fetch-thirdparty-deps-windows.sh #14005

Merged
merged 1 commit into from Sep 10, 2017

Conversation

Projects
None yet
4 participants
@Phrohdoh
Member

Phrohdoh commented Sep 10, 2017

This is #13912 but for Windows builds.

@pchote pchote added this to the Next Release milestone Sep 10, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Sep 10, 2017

Member

This is wanted for the mod sdk, so adding to the milestone.

Member

pchote commented Sep 10, 2017

This is wanted for the mod sdk, so adding to the milestone.

@Mailaender

Not sure what the problem with nuget is exactly, but we don't really need the dependency management plus can't use it for noget.sh compatibility anyway. The certificate checks are also more hassle and I assume problems outweigh the potential security win.

@reaperrr

Dependency fetching still works under Windows (7).

@reaperrr reaperrr merged commit 48a071c into OpenRA:bleed Sep 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Phrohdoh Phrohdoh deleted the Phrohdoh:noget-windows branch Sep 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment