New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EjectOnDeath from RA Vehicles #14021

Merged
merged 1 commit into from Sep 16, 2017

Conversation

Projects
None yet
6 participants
@Smittytron
Contributor

Smittytron commented Sep 14, 2017

Closes #14020

@AoAGeneral

This comment has been minimized.

Show comment
Hide comment
@AoAGeneral

AoAGeneral Sep 15, 2017

Contributor

Shouldn't the QTNK keep the Eject code? Since its a vehicle that is self destructing with an escaping pilot?

Contributor

AoAGeneral commented Sep 15, 2017

Shouldn't the QTNK keep the Eject code? Since its a vehicle that is self destructing with an escaping pilot?

@Smittytron

This comment has been minimized.

Show comment
Hide comment
@Smittytron

Smittytron Sep 15, 2017

Contributor

The pilot actually ejects before the self destruct using different logic. The -Eject line was there to prevent an additional rifleman from spawning after detonation.

Contributor

Smittytron commented Sep 15, 2017

The pilot actually ejects before the self destruct using different logic. The -Eject line was there to prevent an additional rifleman from spawning after detonation.

@AoAGeneral

This comment has been minimized.

Show comment
Hide comment
@AoAGeneral

AoAGeneral Sep 15, 2017

Contributor

Ah I see so the Eject counts for the actual dead vehicle. That makes sense. ^^ nevermind

Contributor

AoAGeneral commented Sep 15, 2017

Ah I see so the Eject counts for the actual dead vehicle. That makes sense. ^^ nevermind

@abcdefg30 abcdefg30 added this to the Next Release milestone Sep 15, 2017

@pchote

pchote approved these changes Sep 15, 2017

@pchote pchote added the PR: Needs +2 label Sep 15, 2017

@SoScared

Works as promised, seem to have caught all rule exceptions as well. Nicely done.

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach Sep 16, 2017

Contributor

This might resolve #4693 from the POV of the RA mod but doesn't implement the actual feature requested there so i disagree with this PR closing that ticket.

Contributor

GraionDilach commented Sep 16, 2017

This might resolve #4693 from the POV of the RA mod but doesn't implement the actual feature requested there so i disagree with this PR closing that ticket.

@pchote pchote merged commit a1ef581 into OpenRA:bleed Sep 16, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Smittytron Smittytron deleted the Smittytron:myfeature branch Oct 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment