New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate MapLocations from LoadMaps. #14075

Merged
merged 1 commit into from Sep 30, 2017

Conversation

Projects
None yet
4 participants
@pchote
Member

pchote commented Sep 25, 2017

Fixes #14066 and #13922 (comment).

Test deb package: Dropbox

Populate MapLocations from LoadMaps.
This ensures that the map locations won't be created by the utility
but means that LoadMaps must be called before attempting to use MapLocations.

@pchote pchote added this to the Next Release milestone Sep 25, 2017

@pchote pchote requested a review from Mailaender Sep 25, 2017

@reaperrr

Code looks good to me

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Sep 27, 2017

Contributor

We still need someone to test this before it's merged.

Contributor

reaperrr commented Sep 27, 2017

We still need someone to test this before it's merged.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Sep 27, 2017

Member

Note that I did test this myself before opening the PR.

Member

pchote commented Sep 27, 2017

Note that I did test this myself before opening the PR.

@Mailaender

I can confirm that this fixes #13922.

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender

Mailaender Sep 30, 2017

Member

No RPM test package due to openSUSE/open-build-service#3930, but I tested a local build.

Member

Mailaender commented Sep 30, 2017

No RPM test package due to openSUSE/open-build-service#3930, but I tested a local build.

@Mailaender Mailaender merged commit a1347a7 into OpenRA:bleed Sep 30, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender
Member

Mailaender commented Sep 30, 2017

@pchote pchote deleted the pchote:fix-utility-maps branch Oct 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment